-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove v1 fields and reconcile logic from dspo #712
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/712/head
git checkout -b pullrequest 064a1e6d7334dab3ad37937c29885cdd42de39d8
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-712" More instructions here on how to deploy and test a Data Science Pipelines Application. |
I think a fine way to test this is to just make sure v2 still works 🤷 |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
FYI this is likely going to go through many significant changes, I would hold off on reviews for now |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
/retest |
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
1 similar comment
Change to PR detected. A new PR build was completed. |
Change to PR detected. A new PR build was completed. |
This change adds a new apiversion "v1", which will remove all the dsp "v1" related fields, and also defaults to dsp "v2". The new apiversion is set as the stored version, however k8s will continue to serve v1alpha1, however it is deprecated. All tests are updated acordingly. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
This change makes it so that new reconciles on dspa owned resources are labelled with a dsp-version=<dspa-version> label. This is to allow for the dspa selectively watch (for manual WatchesRawSources) on resources that are descendents of DSPAs with .spec.dspVersion set to supported versions. Signed-off-by: Humair Khan <HumairAK@users.noreply.github.com>
Change to PR detected. A new PR build was completed. |
The issue resolved by this Pull Request:
Resolves #https://issues.redhat.com/browse/RHOAIENG-13572
Description of your changes:
This PR removes V1 from DSPO, more specifically it:
Testing instructions
DSPA v2 before after upgrade diff, only showing the relevant bits, the rest is the same
When v1 is detected, DSPO will log:
and show the following dspa status:
otherwise the DSPA v1 cr is left untouched, only the removed deprecated fields are synch'd by the cluster.
DSPO logs should not be showing any stacktrace errors.